Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify delete operation in the resource files. #1919

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Conversation

sheneska
Copy link
Contributor

@sheneska sheneska commented Dec 1, 2022

This PR adds a check to the delete function in some resources.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@sheneska sheneska requested a review from a team as a code owner December 1, 2022 17:23
@github-actions github-actions bot added the size/S label Dec 1, 2022
@jrhouston jrhouston merged commit a0511ab into main Dec 5, 2022
@jrhouston jrhouston deleted the idempotent-delete-5 branch December 5, 2022 05:48
shihai1991 added a commit to shihai1991/terraform-provider-kubernetes that referenced this pull request Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants