Make Deleting PVs Idempotent

[sherifabdlnaby]

Description

Add validation on the delete operation for PVs to make it idempotent. (extension of #1914 )

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

Add validation on the delete operation for PVs to make it idempotent.
...

References

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[hashicorp-cla]

All committers have signed the CLA.

[arybolovlev]

Hi @sherifabdlnaby,

Thank you for opening this PR, however, it does not fix the issue you are referring to. This fix extends error handling returned by the method MainClientset() which seems to be the wrong place for NotFound validation.

[alexsomesan]

Thanks for spotting this. @arybolovlev is right, you are checking the error returned by the MainClientSet getter, not the actual Delete operation.

Instead, you should be doing this exact same check with the error on line 328.

Fat-fingered the Approve button. I intended to request changes as per observations of @arybolovlev

[sherifabdlnaby]

@arybolovlev Thanks for spotting my silly mistake, I moved the error check at the delete operation which should work as the PR Intended. @alexsomesan PR Is Updated & Rebased on main 👍🏻

[arybolovlev]

Hi @sherifabdlnaby,

All looks good, just one more query from my end.

Could you please add a changelog file so we can then auto-generate change log for the upcoming release?

It will be a simple text file in .changelog folder. Like this: .changelog/1935.txt. With the following content:

```release-note:enhancement
`resource/kubernetes_persistent_volume`: add additional validation on the delete operation to make it idempotent
```

```release-note:enhancement
`resource/kubernetes_persistent_volume_v1`: add additional validation on the delete operation to make it idempotent
```

Thank you! 👍🏻

[arybolovlev]

Amazing! 👍🏻 Thank you and congratulations on the first-time contribution! 🎉

Your changes will be available in the upcoming release. Please keep an eye on the release notes.

Have a great day!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.