🐛 Fix generic ephemeral volume

[arybolovlev]

Description

Fix spec.volume pod schema to align with the Kubernetes schema. In addition to that fix an issue when the provider crashes when value spec.volume.ephemeral.volume_claim_template.metadata is empty.

Before:

volume {
  name = "this"
  ephemeral {
    metadata {...} // REQUIRED
    spec {...}
  }
}

After:

volume {
  name = "this"
  ephemeral {
    volume_claim_template {
      metadata {...} // OPTIONAL
      spec {...}
    }
  }
}

Links:

• https://kubernetes.io/docs/concepts/storage/ephemeral-volumes/#generic-ephemeral-volumes
• https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#ephemeralvolumesource-v1-core

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS="-vet=off -count 1 -run 'TestAccKubernetesPod_with_ephemeral_storage'"

=== RUN   TestAccKubernetesPod_with_ephemeral_storage
--- PASS: TestAccKubernetesPod_with_ephemeral_storage (10.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-kubernetes/kubernetes	11.568s

GH Workflows: https://github.com/hashicorp/terraform-provider-kubernetes/actions/runs/5621973028

Release Note

Release note for CHANGELOG:

`resource/kubernetes_pod_v1`: add a new volume type `ephemeral` to `spec.volume` to support generic ephemeral volumes.

References

Fix: #2198

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[alexsomesan]

Nice! Many thanks for jumping on this and fixing it!