Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add match_fields to nodeAffinity #2296

Merged
merged 6 commits into from
Sep 27, 2023
Merged

add match_fields to nodeAffinity #2296

merged 6 commits into from
Sep 27, 2023

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Sep 20, 2023

Description

Fixes #2291

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

`kubernetes/schema_affinity_spec.go`: Add `match_fields` to nodeAffinity

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from a team as a code owner September 20, 2023 18:03
@github-actions github-actions bot added size/L and removed size/S labels Sep 22, 2023
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment regarding the schema. An existing function can be re-used. Please, run tests and attach the link to the execution to the PR.

kubernetes/schema_affinity_spec.go Outdated Show resolved Hide resolved
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏻🚀

@BBBmau BBBmau merged commit 32a58d2 into main Sep 27, 2023
11 checks passed
@BBBmau BBBmau deleted the add-matchfields-podaffinity branch September 27, 2023 19:14
dduportal referenced this pull request in jenkins-infra/azure Nov 29, 2023
<Actions>
<action
id="bcd9b70d7c1eb1e07eb5ad8a958f18dc1bbd81461ee1a2604adeea46e3148a47">
        <h3>Bump Terraform `kubernetes` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/kubernetes&#34; updated from &#34;2.23.0&#34; to
&#34;2.24.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.24.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v2.24.0&#xA;ENHANCEMENTS:&#xA;&#xA;`kubernetes/schema_affinity_spec.go`:
Add `match_fields` to nodeAffinity
[[GH-2296](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2296)]&#xA;`kubernetes/schema_pod_spec.go`:
Add `os` to podSpecFields
[[GH-2290](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2290)]&#xA;`resource/kubernetes_config_map_v1_data`:
improve error handling while validating the existence of the target
ConfigMap.
[[GH-2230](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2230)]&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `resource/kubernetes_labels`: Add
[&#34;f:metadata&#34;] check in kubernetes_labels to prevent crash with
kubernetes_node_taints
[[GH-2246](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2246)]&#xA;&#xA;DOCS:&#xA;&#xA;*
Add example module for configuring OIDC authentication on EKS
[[GH-2287](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2287)]&#xA;*
Add example module for configuring OIDC authentication on GKE
[[GH-2319](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2319)]&#xA;&#xA;NOTES:&#xA;&#xA;*
Bump Go version from 1.20 to 1.21.
[[GH-2337](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2337)]&#xA;*
Bump Kubernetes dependencies from x.25.11 to
x.27.8.&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/905/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match_fields not expected in deployments' nodeAffinity
2 participants