Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kubernetes_service data source #23

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Add kubernetes_service data source #23

merged 1 commit into from
Jul 18, 2017

Conversation

radeksimko
Copy link
Member

Closes #13

Test Results

$ make testacc TEST=./kubernetes TESTARGS='-run=TestAccKubernetesDataSourceService_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./kubernetes -v -run=TestAccKubernetesDataSourceService_basic -timeout 120m
=== RUN   TestAccKubernetesDataSourceService_basic
--- PASS: TestAccKubernetesDataSourceService_basic (4.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	4.186s

@bonifaido
Copy link

What is the target release date for this change?

@radeksimko
Copy link
Member Author

@bonifaido There is no specific target at this point, once a maintainer reviews the PR and gives it 👍 I can cut the release, but I was thinking of bundling #22 with the next release.

grubernaut
grubernaut approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@radeksimko radeksimko merged commit 6b948c8 into master Jul 18, 2017
@radeksimko radeksimko deleted the f-svc-data-source branch July 18, 2017 05:30
ddub pushed a commit to ddub/terraform-provider-kubernetes that referenced this pull request Jun 21, 2018
@sl1pm4t
Use Update() instead of Patch() to update svc
c1e3a8c 
Fixes hashicorp#23
mbarrien pushed a commit to chanzuckerberg/terraform-provider-kubernetes that referenced this pull request Feb 20, 2019
@sl1pm4t @mbarrien
Use Update() instead of Patch() to update svc
32a2c35 
Fixes hashicorp#23
@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Kubernetes Service data source
3 participants
@radeksimko @bonifaido @grubernaut