Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new field volume_mode to kubernetes_persistent_volume_claim(_v1) #2353

Merged
merged 8 commits into from
Nov 30, 2023

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Nov 27, 2023

Description

This PR adds a new attribute volume_mode to the following resource:

  • kubernetes_persistent_volume_claim
  • kubernetes_persistent_volume_claim_v1
  • kubernetes_stateful_set
  • kubernetes_stateful_set_v1

More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#volume-mode

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Release Note

Release note for CHANGELOG:

`resource/kubernetes_persistent_volume_claim`: add a new field `volume_mode`.
`resource/kubernetes_persistent_volume_claim_v1`: add a new field `volume_mode`.
`resource/kubernetes_stateful_set`: add a new attribute `spec.volume_claim_template.spec.volume_mode`.
`resource/kubernetes_stateful_set_v1`: add a new attribute `spec.volume_claim_template.spec.volume_mode`.
`data_source/kubernetes_persistent_volume_claim`: add a new attribute `spec.volume_mode`.
`data_source/kubernetes_persistent_volume_claim_v1`: add a new attribute `spec.volume_mode`.

References

Fix: #2350

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@arybolovlev arybolovlev marked this pull request as ready for review November 27, 2023 16:48
@arybolovlev arybolovlev requested a review from a team as a code owner November 27, 2023 16:48
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@arybolovlev arybolovlev merged commit 96b44b0 into main Nov 30, 2023
15 checks passed
@arybolovlev arybolovlev deleted the add-pvc-volume-mode branch November 30, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes_persistent_volume_claim to support volume_mode for Block volumes
2 participants