Allow HugePages in emptyDir.medium. #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@gram-signal I tried locally and it's working for me. Would you mind signing the CLA to make the approval/merge faster? |
BBBmau
requested changes
Jan 11, 2024
|
CLA signed :) |
|
@gram-signal one last request would be to create a |
|
also to fix the test format from the failing checker: |
Looks like someone beat me to it :) |
|
I went ahead and added the It'll be easier to locate once we're done rewriting the contribution guide |
BBBmau
approved these changes
Jan 13, 2024
dduportal
referenced
this pull request
in jenkins-infra/azure
Feb 19, 2024
<Actions>
<action
id="bcd9b70d7c1eb1e07eb5ad8a958f18dc1bbd81461ee1a2604adeea46e3148a47">
<h3>Bump Terraform `kubernetes` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>changes detected:
	"hashicorp/kubernetes" updated
from "2.25.2" to "2.26.0" in file
".terraform.lock.hcl"</p>
<details>
<summary>2.26.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v2.26.0
ENHANCEMENTS:

*
`kubernetes/kubernetes_deployment_v1`: Add support for `HugePages` in
`emptyDir.medium`
[[GH-2395](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2395)]
*
`resource/kubernetes_job_v1`: add new attribute
`spec.pod_failure_policy` to job spec
[[GH-2394](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2394)]

NOTES:

*
Bump Kubernetes dependencies from x.27.8 to x.28.6.
[[GH-2404](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2404)]


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/3/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2302 by allowing the values
HugePages,HugePages-2Mi, andHugePages-1GiinemptyDir.medium.Release Note
Release note for CHANGELOG:
References
#2302
https://kubernetes.io/docs/tasks/manage-hugepages/scheduling-hugepages/
Community Note