Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/service: Make port optional field #27

Merged
merged 1 commit into from
Jul 18, 2017
Merged

r/service: Make port optional field #27

merged 1 commit into from
Jul 18, 2017

Conversation

radeksimko
Copy link
Member

Fixes #26

make testacc TEST=./kubernetes TESTARGS='-run=TestAccKubernetesService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./kubernetes -v -run=TestAccKubernetesService_ -timeout 120m
=== RUN   TestAccKubernetesService_basic
--- PASS: TestAccKubernetesService_basic (0.69s)
=== RUN   TestAccKubernetesService_loadBalancer
--- PASS: TestAccKubernetesService_loadBalancer (56.37s)
=== RUN   TestAccKubernetesService_nodePort
--- PASS: TestAccKubernetesService_nodePort (0.33s)
=== RUN   TestAccKubernetesService_externalName
--- PASS: TestAccKubernetesService_externalName (0.30s)
=== RUN   TestAccKubernetesService_importBasic
--- PASS: TestAccKubernetesService_importBasic (0.36s)
=== RUN   TestAccKubernetesService_generatedName
--- PASS: TestAccKubernetesService_generatedName (0.32s)
=== RUN   TestAccKubernetesService_importGeneratedName
--- PASS: TestAccKubernetesService_importGeneratedName (0.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	58.939s

@radeksimko radeksimko added the bug label Jul 12, 2017
@radeksimko radeksimko mentioned this pull request Jul 12, 2017
Closed
grubernaut
grubernaut approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@radeksimko radeksimko merged commit a85fc4b into master Jul 18, 2017
@radeksimko radeksimko deleted the b-service-optional-port branch July 18, 2017 05:29
@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubernetes_service requires port to be set in situations where kubernetes API doesn't.
2 participants
@radeksimko @grubernaut