Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data source for K8s storage class #33

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Data source for K8s storage class #33

merged 1 commit into from
Jul 25, 2017

Conversation

ashishth09
Copy link
Contributor

@ashishth09 ashishth09 commented Jul 25, 2017 •
edited
Loading

Hello,
We need a data source for storage class resource in one of our automation paths. This is an effort towards adding the same.

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./kubernetes -v -run TestAccKubernetesDataSourceStorageClass_basic -timeout 120m
=== RUN   TestAccKubernetesDataSourceStorageClass_basic
--- PASS: TestAccKubernetesDataSourceStorageClass_basic (0.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	0.321s

radeksimko
radeksimko approved these changes Jul 25, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. 👍

Just a friendly advice for future contributions: it makes it easier for everyone (yourself + reviewers) if you open a PR from a separate branch, rather than master. 😉

@radeksimko radeksimko merged commit 6ab5b8e into hashicorp:master Jul 25, 2017
@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashishth09 @radeksimko