d/workspace external_id

[mbevc1]

Is there any reason to keep this warning https://github.com/hashicorp/terraform-provider-tfe/blob/master/tfe/data_source_workspace.go#L13 ? Assuming in the next release we can remove this from r/ d/ resources?

[chrisarcand]

Hi!

As the messages says, more details this deprecation can be found in the changelog:

All deprecated attributes will be removed 3 months after the release of v0.24.0 (April 21, 2021).

d/tfe_workspace: The deprecation warning for the external_id attribute will not go away until the attribute is removed in a future version. This is due to a limitation of the Terraform SDK for deprecation warnings on attributes that aren't specified in a configuration. If you have already changed all references to this data source's external_id attribute to the ids attribute, you can ignore the warning.

So - not necessarily the next release, but a release on or past the specified date.

I do empathize with any annoyance of the deprecation warning not able to be resolved in any way, and hope to remove it ASAP - but this is a common workaround for the limitations of the SDK at the moment and was used from the start of this long migration for workspace IDs. We intend to see it through for at least this particular set of changes.

Thanks!

[mbevc1]

Yeah, it's a bit misleading with data resource as it's bot using that argument in the code itself.

[chrisarcand]

I agree completely 👍 In my own opinion, I wouldn't use this schema mechanism in the future even if the SDK still doesn't allow for warnings at-access when a configuration is actually evaluated; it just gets too noisy. (More thoughts here)

Here's the issue tracking this ability, if you're curious: hashicorp/terraform#7569

[mbevc1]

Indeed, cheers and thanks for related discussions 👍 . Wanted to check first before opening a PR and trying to remove those here 🙂