Bug: Prevent empty string to be used as default health_check_type

[radeksimko]

I guess this bug has been introduced along with swapping the AWS libraries.

If you run following sample template:

provider "aws" {
  region = "eu-west-1"
}

resource "aws_launch_configuration" "foo" {
  name = "sample"
  image_id = "ami-8f0087f8"
  instance_type = "t1.micro"
}

resource "aws_autoscaling_group" "bar" {
  availability_zones = ["eu-west-1a"]
  name = "sample"
  max_size = 5
  min_size = 2

  launch_configuration = "${aws_launch_configuration.foo.name}"
}

you'll see following error:

Error creating Autoscaling Group: 1 validation error detected: Value '' at 'healthCheckType' failed to satisfy constraint: Member must have length greater than or equal to 1

The proposed change will only pass health_check_type to the underlying library if it's actually defined.

cc @catsby

[mitchellh]

I think this should be a GetOk and the check should be ok && v.(string) != ""

[radeksimko]

ah, right, I see, I will change it then.

[radeksimko]

Fixed the check as requested.

[pearkes]

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.