provider/aws: Enable snapshotting by default on aws_redshift_cluster #11695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack72
force-pushed
the
f-aws-redshift-snapshot-default
branch
from
c27b065
to
603a006
Compare
radeksimko
reviewed
Feb 15, 2017
| } | ||
| } | ||
|
|
||
| snapshot_identifier := "tf-acctest-snapshot-1" |
There was a problem hiding this comment.
Similarly to RDS snapshots I think we should randomize the snapshot IDs here.
stack72
force-pushed
the
f-aws-redshift-snapshot-default
branch
4 times, most recently
from
960b621
to
0b93f18
Compare
This extends the work in #11668 to enable final snapshots by default. This time it's for redshift ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRedshiftCluster_withFinalSnapshot' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/02/04 13:53:02 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRedshiftCluster_withFinalSnapshot -timeout 120m === RUN TestAccAWSRedshiftCluster_withFinalSnapshot --- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (859.96s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 859.986s ```
stack72
force-pushed
the
f-aws-redshift-snapshot-default
branch
from
0b93f18
to
87add09
Compare
radeksimko
approved these changes
Feb 15, 2017
minamijoyo
added a commit
to minamijoyo/terraform-provider-aws
that referenced
this pull request
Jul 11, 2017
The default value of `skip_final_snapshot` was changed to `false` with the following change, but the document was not updated. hashicorp/terraform#11695
stack72
pushed a commit
to hashicorp/terraform-provider-aws
that referenced
this pull request
Jul 11, 2017
…1121) The default value of `skip_final_snapshot` was changed to `false` with the following change, but the document was not updated. hashicorp/terraform#11695
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the work in #11668 to enable final snapshots by default.
This time it's for redshift