provider/cloudstack: do not force a new resource when updating load b… #11786
Conversation
| for _, i := range l.LoadBalancerRuleInstances { | ||
| mbs = append(mbs, i.Id) | ||
| } | ||
| d.Set("member_ids", mbs) |
There was a problem hiding this comment.
Does this work? Is this then added as a set? Didn't know that 😉
| log.Printf("[DEBUG] Members to add: %v, remove: %v", membersToAdd, membersToRemove) | ||
|
|
||
| if len(membersToAdd) > 0 { | ||
| ap := cs.LoadBalancer.NewAssignToLoadBalancerRuleParams(d.Id()) |
There was a problem hiding this comment.
nitting can you make that just p instead of ap? The ap used in the create function is only used because p was already used in the same scope...
| } | ||
|
|
||
| if len(membersToRemove) > 0 { | ||
| ap := cs.LoadBalancer.NewRemoveFromLoadBalancerRuleParams(d.Id()) |
There was a problem hiding this comment.
nitting same goes for this one of course...
|
Anything more needed to get this merged? |
|
LGTM! Sorry for the delay @serbaut! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
…alancer members