Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix flattened cloudfront lambda function associations t… #11984

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

jakepusateri
Copy link
Contributor

…o be a set, not a slice

Fixes #11925

@pxlpnk
Copy link

pxlpnk commented Mar 9, 2017

Is there a plan to get this merged?

@majormoses
Copy link
Contributor

@stack72 any chance of getting this looked at?

@stack72
Copy link
Contributor

stack72 commented Mar 20, 2017

LGTM! Thanks for the work here - sorry it took so long to merge!

Paul

@stack72 stack72 merged commit c7546c7 into hashicorp:master Mar 20, 2017
mbfrahry pushed a commit that referenced this pull request Mar 28, 2017
@s-nakka
Copy link

s-nakka commented May 9, 2017

https://www.terraform.io/docs/providers/aws/r/lambda_event_source_mapping.html
This document says "The event source ARN - can either be a Kinesis or DynamoDB stream". I don't see an option to attach cloudfront as a source trigger to lambda (edge). Using Terraform v0.9.3.

@elblivion
Copy link
Contributor

@SandyFox IIUC you have to set it in Cloudfront, not as a regular event source mapping: https://www.terraform.io/docs/providers/aws/r/cloudfront_distribution.html#lambda_function_association

@s-nakka
Copy link

s-nakka commented May 9, 2017

Great thank you, but It would be nice to control it from lambda too. When there is an option in the console I believe it should be in CLI too.

@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error setting up a CloudFront distribution with a Lambda@Edge function
6 participants