fix windows locks #12059
Merged
fix windows locks #12059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't create a new windows handle for the lock.
mitchellh
reviewed
Feb 17, 2017
| delete(lockedFiles, s.stateFileOut) | ||
| return syscall.Close(handle) | ||
| // the file is closed in Unlock | ||
| return nil |
There was a problem hiding this comment.
What does this mean? We are unlocked automatically on file close? When does that happen?
There was a problem hiding this comment.
Oh yes, file is unocked when the associated handle is closed. This happens automatically when Close is called in the main Unlock method.
mitchellh
approved these changes
Feb 17, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't create a second windows handle for the lock file.
Fixes #12012