Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSH Agent #1208

Merged
merged 5 commits into from
Apr 2, 2015
Merged

Add support for SSH Agent #1208

merged 5 commits into from
Apr 2, 2015

Conversation

keyneston
Copy link

No description provided.

@mitchellh
Copy link
Contributor

This is a great start! Noted on your need to close the socket but I see there isn't a good place yet. But so far so good. 👍

@mitchellh
Copy link
Contributor

Let me know when you want me to take another look.

@keyneston
Copy link
Author

I added a cleanup function and added calls to it everywhere that seemed appropriate. Feel free to let me know of any additional changes you require or would like.

On a side note thanks for this project! I love it and my coworkers are quickly coming to love it also.

@mitchellh
Copy link
Contributor

LGTM. This looks great. Thanks so much for the great PR as well as docs. You also touched probably the only feature that isn't unit tested. :) So, no tests needed. Coming in.

mitchellh added a commit that referenced this pull request Apr 2, 2015
Add support for SSH Agent
@mitchellh mitchellh merged commit 8ee6a03 into hashicorp:master Apr 2, 2015
@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants