Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/terraform: remote state data source supports backends #12173

Merged
merged 3 commits into from
Feb 23, 2017

Conversation

mitchellh
Copy link
Contributor

This changes the terraform_remote_state data source to support backends rather than going through the legacy remote state interface.

To support this change without duplicating the list of backends, I introduce a new package backend/init which simply provides an API for looking up backend initializers. The command package was changed to use this as well. This means that we have a uniform way to lookup and initialize a backend.

@mitchellh mitchellh added this to the Terraform 0.9 milestone Feb 22, 2017
backendlegacy "github.com/hashicorp/terraform/backend/legacy"
backendlocal "github.com/hashicorp/terraform/backend/local"
backendconsul "github.com/hashicorp/terraform/backend/remote-state/consul"
backendinmem "github.com/hashicorp/terraform/backend/remote-state/inmem"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not to block this PR, but I wonder if we need some general refactoring/cleanup regarding around the backend packages. some of these import blocks are getting messy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so since its no different than our internal_plugin_list.go file. That file happens to be generated now (it used to not!), but its just like this. The full list of built-in things has to be enumerated somewhere and backend/init is where that's happening. I think as long as we do this only in one place we're good to go, cause its going to happen somewhere anyways.

@mitchellh mitchellh merged commit 8f11068 into master Feb 23, 2017
@mitchellh mitchellh deleted the b-remote-state-ds branch February 23, 2017 02:43
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants