Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_api_gateway_integration resources not getting updated properly. #12233

Closed
naikajah opened this issue Feb 24, 2017 · 2 comments
Closed

aws_api_gateway_integration resources not getting updated properly. #12233

naikajah opened this issue Feb 24, 2017 · 2 comments

Comments

@naikajah
Copy link

naikajah commented Feb 24, 2017

Terraform Version

Terraform v8.7

Affected Resource(s)

aws_api_gateway_integration

Terraform Configuration

My terraform configuration for aws_api_gateway_integration

resource "aws_api_gateway_integration" "testMockGET" {
  rest_api_id             = "${aws_api_gateway_rest_api.test.id}"
  resource_id             = "${aws_api_gateway_resource.testMock.id}"
  type                    = "MOCK"
  uri                     = "/test"
  http_method             = "${aws_api_gateway_method.testGET.http_method}"
}

Expected Behavior

After the first plan and apply created the resource in AWS. The subsequent plan and apply shouldn't modify the resource unless there is any change in the resource definition.

Actual Behavior

After the first plan and apply creates the resource properly all the subsequent plan shows that there is an update even though there are none and apply updates the URI parameter with the same value again and again.

~ module.TEST.aws_api_gateway_integration.testMockGET
 uri: "" => "/test"

This is then leading to #9877

Steps to Reproduce

  1. terraform plan original definition
  2. terraform apply original definition
  3. terraform plan/apply

After looking at the repo, I see that for api_gateway_integration resource we have same method which is resourceAwsApiGatewayIntegrationCreate where as for other resources e.g. api_gateway_method we have an resourceAwsApiGatewayMethodUpdate which takes care of checking if the value has changed.

Create: resourceAwsApiGatewayIntegrationCreate,
Update: resourceAwsApiGatewayIntegrationCreate,

Shouldn't there be an Update: resourceAwsApiGatewayIntegrationUpdate for Integration resource that checks for hasChanged().
could this be a problem here?

@stack72
Copy link
Contributor

stack72 commented Mar 31, 2017

Closed via #13249

@stack72 stack72 closed this as completed Mar 31, 2017
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants