Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/provider: Fixes issue for aws_lb_ssl_negotiation_policy of already deleted ELB #12360

Merged
merged 3 commits into from
Mar 6, 2017
Merged

aws/provider: Fixes issue for aws_lb_ssl_negotiation_policy of already deleted ELB #12360

merged 3 commits into from
Mar 6, 2017

Conversation

bclodius
Copy link
Contributor

@bclodius bclodius commented Mar 2, 2017

Fixes #11260

@stack72
Copy link
Contributor

stack72 commented Mar 2, 2017

Hi @bclodius

Thanks for the work on this - please can you add an acceptance test to show that this works as expected? Please feel free to shout if you need some guidance in this area

Thanks

Paul

@stack72 stack72 added bug provider/aws waiting-response An issue/pull request is waiting for a response from the community labels Mar 2, 2017
@bclodius
Copy link
Contributor Author

bclodius commented Mar 2, 2017

@stack72 certainly. I will take a stab at this and let you know if I need some help.

@bclodius
Copy link
Contributor Author

bclodius commented Mar 2, 2017

@stack72 when I comment c5b36c7 I am able to reproduce the issue. Below is the test case i ran.

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLBSSLNegotiationPolicy_missingLB'

@stack72
Copy link
Contributor

stack72 commented Mar 6, 2017

nice work @bclodius

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLBSSLNegotiationPolicy_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/06 13:39:11 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLBSSLNegotiationPolicy_ -timeout 120m
=== RUN   TestAccAWSLBSSLNegotiationPolicy_basic
--- PASS: TestAccAWSLBSSLNegotiationPolicy_basic (42.73s)
=== RUN   TestAccAWSLBSSLNegotiationPolicy_missingLB
--- PASS: TestAccAWSLBSSLNegotiationPolicy_missingLB (88.50s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	131.253s

LGTM!

@stack72 stack72 merged commit 22f69b1 into hashicorp:master Mar 6, 2017
stack72 pushed a commit that referenced this pull request Mar 6, 2017
…y deleted ELB (#12360)

* Ensures elb exists before negotiation policy check; Fixes #11260

* Adds acceptance test case for missing elb

* Adds back https properties for test elb
@bclodius
Copy link
Contributor Author

bclodius commented Mar 6, 2017

Thanks @stack72!!!

yanndegat pushed a commit to yanndegat/terraform that referenced this pull request Mar 13, 2017
…y deleted ELB (hashicorp#12360)

* Ensures elb exists before negotiation policy check; Fixes hashicorp#11260

* Adds acceptance test case for missing elb

* Adds back https properties for test elb
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error deleting SSL negotiation policy - There is no ACTIVE Load Balancer
2 participants