provider/statuscake: use default status code list when updating test #12375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks for the work on this :) |
stack72
pushed a commit
that referenced
this pull request
Mar 5, 2017
yanndegat
pushed a commit
to yanndegat/terraform
that referenced
this pull request
Mar 13, 2017
samcrang
added a commit
to openregister/deployment
that referenced
this pull request
Mar 17, 2017
There is some slight ugliness to work around the new backend configuration in 0.9.0 and the fact it doesn't support interpolations. In the short-term this means we can upgrade to 0.9.0 and get the [StatusCake bug fix](hashicorp/terraform#12375) we need without having to change significantly how we use and deploy Terraform. We should probably look at using [Terraform State Environments](https://www.terraform.io/docs/state/environments.html) instead.
samcrang
added a commit
to openregister/deployment
that referenced
this pull request
Mar 17, 2017
There is some slight ugliness to work around the new backend configuration in 0.9.0 and the fact it doesn't support interpolations. In the short-term this means we can upgrade to 0.9.0 and get the [StatusCake bug fix](hashicorp/terraform#12375) we need without having to change significantly how we use and deploy Terraform. We should probably look at using [Terraform State Environments](https://www.terraform.io/docs/state/environments.html) instead.
samcrang
added a commit
to openregister/deployment
that referenced
this pull request
Mar 17, 2017
There is some slight ugliness to work around the new backend configuration in 0.9.0 and the fact it doesn't support interpolations. In the short-term this means we can upgrade to 0.9.0 and get the [StatusCake bug fix](hashicorp/terraform#12375) we need without having to change significantly how we use and deploy Terraform. We should probably look at using [Terraform State Environments](https://www.terraform.io/docs/state/environments.html) instead.
samcrang
added a commit
to openregister/deployment
that referenced
this pull request
Mar 17, 2017
There is some slight ugliness to work around the new backend configuration in 0.9.0 and the fact it doesn't support interpolations. In the short-term this means we can upgrade to 0.9.0 and get the [StatusCake bug fix](hashicorp/terraform#12375) we need without having to change significantly how we use and deploy Terraform. We should probably look at using [Terraform State Environments](https://www.terraform.io/docs/state/environments.html) instead.
samcrang
added a commit
to openregister/deployment
that referenced
this pull request
Mar 17, 2017
There is some slight ugliness to work around the new backend configuration in 0.9.0 and the fact it doesn't support interpolations. In the short-term this means we can upgrade to 0.9.0 and get the [StatusCake bug fix](hashicorp/terraform#12375) we need without having to change significantly how we use and deploy Terraform. We should probably look at using [Terraform State Environments](https://www.terraform.io/docs/state/environments.html) instead.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue whenever a StatusCake test is updated which would clear the list of status codes considered as errors.
According to the StatusCake API documentation (https://github.com/DreamItGetIT/statuscake/blob/master/tests.go#L93), when updating a test definition the
StatusCodesdefinition is always updated. Since currently there's no support for setting the list of status codes in terraform this would replace the list with an empty list.This PR fixes the issue by always providing the default list of status codes when updating a test.