Add log message about if changes are being applied now or later #12691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbednarski
reviewed
Mar 14, 2017
| @@ -839,6 +839,10 @@ func resourceAwsDbInstanceUpdate(d *schema.ResourceData, meta interface{}) error | |||
| } | |||
| d.SetPartial("apply_immediately") | |||
|
|
|||
| if !d.Get("apply_immediately").(bool) { | |||
| log.Println("[INFO] Only settings updating, instances changes applied in next maintenance window") | |||
There was a problem hiding this comment.
instances changes applied -> instance changes will be applied
cbednarski
reviewed
Mar 14, 2017
| @@ -839,6 +839,10 @@ func resourceAwsDbInstanceUpdate(d *schema.ResourceData, meta interface{}) error | |||
| } | |||
| d.SetPartial("apply_immediately") | |||
|
|
|||
| if !d.Get("apply_immediately").(bool) { | |||
| log.Println("[INFO] Only settings updating, instances changes will be applied in next maintenance window") | |||
There was a problem hiding this comment.
instances changes -> instance changes
cbednarski
approved these changes
Mar 14, 2017
stack72
pushed a commit
that referenced
this pull request
Mar 15, 2017
* Add log message about if changes are being applied now or later * Improve english * Further adventure in english
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
apply_immediatelyis spelled out clearly in the docs, but it's easy for users (such as myself) to misunderstand, forget, or not read in the first place. A simple log message informing them that the only thing being applied at this time is the settings helps users avoid confusion.