Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Increase AMI destroy timeout #12943

Merged
merged 3 commits into from
Mar 22, 2017

Conversation

grubernaut
Copy link
Contributor

Acceptance tests were timing out on AMI destroy, should alleviate the problem.

Acceptance tests were timing out on AMI destroy, should alleviate the problem.
@grubernaut
Copy link
Contributor Author

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAMI'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/21 23:30:22 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAMI -timeout 120m
=== RUN   TestAccAWSAMICopy
--- PASS: TestAccAWSAMICopy (471.51s)
=== RUN   TestAccAWSAMIFromInstance
--- PASS: TestAccAWSAMIFromInstance (111.38s)
=== RUN   TestAccAWSAMILaunchPermission_Basic
--- PASS: TestAccAWSAMILaunchPermission_Basic (400.12s)
=== RUN   TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_basic (60.72s)
=== RUN   TestAccAWSAMI_snapshotSize
--- PASS: TestAccAWSAMI_snapshotSize (59.70s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    1103.466s

resource.TestStep{
Config: testAccAWSAMIFromInstanceConfig,
{
Config: fmt.Sprintf(testAccAWSAMIFromInstanceConfig, rInt),
Copy link
Member

@radeksimko radeksimko Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually wrap these in a function, merely to avoid test failures and confusions caused by reusing such configs and forgetting to pass the integer. Function with argument can enforce this at compilation time, which is nice.

With all that said it's probably a nitpick. :)

@grubernaut grubernaut merged commit be2af3f into master Mar 22, 2017
@grubernaut grubernaut deleted the b-update-ami-destroy-timeout branch March 22, 2017 13:27
mbfrahry pushed a commit that referenced this pull request Mar 28, 2017
* provider/aws: Increase AMI destroy timeout

Acceptance tests were timing out on AMI destroy, should alleviate the problem.

* Further increase timeout, cleanup test

* use function instead of printf
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants