provider/aws: aws_ses_receipt_rule: fix off-by-one errors

[dougneal]

In function resourceAwsSesReceiptRuleRead the position of the receipt rules in the rule set was taken directly from the index of the rule's position in the slice returned by the AWS API call. As the slice is zero-based and the ruleset is one-based, this results in an incorrect representation.

This manifests as aws_ses_receipt_rule resources always showing a diff during plan or apply.

[stack72]

Hi @dougneal

Thanks for the work here - is it possible to post a config that shows the error manifesting itself? I'd like to understand if there is a potential issue for users who upgrade

Thanks

Paul

[dougneal]

Hi @stack72, yeah sure, I'll put something together.

[stack72]

<3 for this :)

[dougneal]

With the following configuration:

variable "s3_bucket_name" {
  type = "string"
}

resource "aws_ses_receipt_rule" "terraform-pr-12961" {
  name = "terraform-pr-12961"
  rule_set_name = "default-rule-set"
  recipients = ["admin@example.com"]
  enabled = true
  s3_action = {
    position = 1
    bucket_name = "${var.s3_bucket_name}"
    object_key_prefix = "ses/terraform-pr-12961"
  }
}

Then applying from a blank state:

$ terraform apply .
aws_ses_receipt_rule.terraform-pr-12961: Creating...
  enabled:                               "" => "true"
  name:                                  "" => "terraform-pr-12961"
  recipients.#:                          "" => "1"
  recipients.1433171261:                 "" => "admin@example.com"
  rule_set_name:                         "" => "default-rule-set"
  s3_action.#:                           "" => "1"
  s3_action.618256378.bucket_name:       "" => "<redacted>"
  s3_action.618256378.kms_key_arn:       "" => ""
  s3_action.618256378.object_key_prefix: "" => "ses/terraform-pr-12961"
  s3_action.618256378.position:          "" => "1"
  s3_action.618256378.topic_arn:         "" => ""
  scan_enabled:                          "" => "<computed>"
  tls_policy:                            "" => "<computed>"
aws_ses_receipt_rule.terraform-pr-12961: Creation complete (ID: terraform-pr-12961)

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

The state of your infrastructure has been saved to the path
below. This state is required to modify and destroy your
infrastructure, so keep it safe. To inspect the complete state
use the `terraform show` command.

State path:

And running apply again immediately afterwards, showing that the state of the resource as read from the API doesn't match the representation as computed from the config:

$ terraform apply .
aws_ses_receipt_rule.terraform-pr-12961: Refreshing state... (ID: terraform-pr-12961)
aws_ses_receipt_rule.terraform-pr-12961: Modifying... (ID: terraform-pr-12961)
  s3_action.1036183227.bucket_name:       "<redacted>" => ""
  s3_action.1036183227.kms_key_arn:       "" => ""
  s3_action.1036183227.object_key_prefix: "ses/terraform-pr-12961" => ""
  s3_action.1036183227.position:          "0" => "0"
  s3_action.1036183227.topic_arn:         "" => ""
  s3_action.618256378.bucket_name:        "" => "<redacted>"
  s3_action.618256378.kms_key_arn:        "" => ""
  s3_action.618256378.object_key_prefix:  "" => "ses/terraform-pr-12961"
  s3_action.618256378.position:           "" => "1"
  s3_action.618256378.topic_arn:          "" => ""
aws_ses_receipt_rule.terraform-pr-12961: Modifications complete (ID: terraform-pr-12961)

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

[stack72]

Awesome! Thanks for this @dougneal :)

This is exactly what I needed

LGTM

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.