provider/alicloud: Fix allocate public ip error (#13267)

[pragkent]

Wait for instance to be in STOPPED or RUNNING state before invoking
AllocatePublicIP API.

• provider/alicloud: Wait for instance state before allocate public ip

• provider/alicloud: Fix test TestAccAlicloudInstance_associatePublicIP

• provider/alicloud: Update alicloud_instance document

Fixes: #13267

[pragkent]

TEST:

make testacc TEST=./builtin/providers/alicloud TESTARGS=-run='TestAccAlicloudInstance_associatePublicIP'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/01 12:59:09 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/alicloud -v -run=TestAccAlicloudInstance_associatePublicIP -timeout 120m
=== RUN TestAccAlicloudInstance_associatePublicIP
--- PASS: TestAccAlicloudInstance_associatePublicIP (113.80s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/alicloud 113.823s

[pragkent]

Hi, is there anything else should I do before this PR could be merged?

[stack72]

Hi @pragkent

This LGTM! Thanks for the work here :)

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.