Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket_prefix to aws_s3_bucket #13274

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Add bucket_prefix to aws_s3_bucket #13274

merged 1 commit into from
Apr 20, 2017

Conversation

joshuaspence
Copy link
Contributor

Adds a bucket_prefix parameter to the aws_s3_bucket resource.

@joshuaspence
Copy link
Contributor Author

> make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSS3Bucket_\(namePrefix\|generatedName\)'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/02 15:35:28 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSS3Bucket_\(namePrefix\|generatedName\) -timeout 120m
=== RUN   TestAccAWSS3Bucket_namePrefix
--- PASS: TestAccAWSS3Bucket_namePrefix (105.94s)
=== RUN   TestAccAWSS3Bucket_generatedName
--- PASS: TestAccAWSS3Bucket_generatedName (81.40s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	187.358s

Adds a `bucket_prefix` parameter to the `aws_s3_bucket` resource.
@stack72
Copy link
Contributor

stack72 commented Apr 20, 2017

LGTM! Thanks for this :)

@stack72 stack72 merged commit f3b5a88 into hashicorp:master Apr 20, 2017
@joshuaspence joshuaspence deleted the name_prefix-s3_bucket branch April 22, 2017 11:21
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants