Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws_s3_bucket diff of logging options #13281

Merged
merged 1 commit into from
Apr 5, 2017

Conversation

ameir
Copy link
Contributor

@ameir ameir commented Apr 3, 2017

If aws_s3_bucket logging options are cleared on the AWS side, Terraform does not detect this, and changes must be made out-of-band or through a recreation of the resource. This PR addresses this issue.

Fixes #8576.

…form does not detect this, and changes must be made out-of-band or through a recreation of the resource. This PR addresses this issue.

Fixes hashicorp#8576.
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@catsby catsby merged commit 7cd0708 into hashicorp:master Apr 5, 2017
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 logging options are not updated on existing bucket
3 participants