Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for StatusCake TriggerRate field #13340

Closed

Conversation

ruippeixotog
Copy link
Contributor

This PR adds a new "TriggerRate" field to statuscake_test so that it can be passed to the StatusCake API.

@stack72
Copy link
Contributor

stack72 commented Apr 5, 2017

Hi @ruippeixotog

I just ran the tests for this and they are not working - this suspects me to believe that the go library isn't setting the value correctly
I will fix that library up and then get back to you asap

Paul

@stack72
Copy link
Contributor

stack72 commented Apr 5, 2017

PR sent to the upstream library here DreamItGetIT/statuscake#9

@stack72
Copy link
Contributor

stack72 commented Apr 5, 2017

Deps update

#13387

@ruippeixotog
Copy link
Contributor Author

Wow, that was fast, thanks! I'm sorry I couldn't run the acceptance tests, there was something wrong with my environment and I couldn't run any acceptance test at all, even on master...

I'm glad the upstream library accepted the PR fast. Should I wait until #13387 is accepted and rebase this PR afterwards?

@stack72
Copy link
Contributor

stack72 commented Apr 7, 2017

Hi @ruippeixotog

So I have had a PR accepted to the upstream repo - then had to open another :)

I will manually merge this and paste the output of the tests here

Thanks for all the work here

Paul

@stack72
Copy link
Contributor

stack72 commented Apr 10, 2017

Hi @ruippeixotog

Thanks for the work - I just manually rebased this and it looks good now :) I have merged manually

% make testacc TEST=./builtin/providers/statuscake                                                                                           ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/10 15:38:42 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/statuscake -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccStatusCake_basic
--- PASS: TestAccStatusCake_basic (10.46s)
=== RUN   TestAccStatusCake_tcp
--- PASS: TestAccStatusCake_tcp (4.42s)
=== RUN   TestAccStatusCake_withUpdate
--- PASS: TestAccStatusCake_withUpdate (5.41s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/statuscake	20.309s

Paul

@stack72 stack72 closed this Apr 10, 2017
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants