Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for CustomOrigin timeouts to aws_cloudfront_distribution #13367

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Apr 5, 2017

Currently, any changes / deletions to aws_cloudfront resources with a custom_origin are completely broken

aws_cloudfront_distribution.custom_distribution: Destroying... (ID: EC5N584ZA1U1D)
Error applying plan:

1 error(s) occurred:

* aws_cloudfront_distribution.custom_distribution (destroy): 1 error(s) occurred:

* aws_cloudfront_distribution.custom_distribution: IllegalUpdate: OriginReadTimeout is required for updates.
	status code: 400, request id: dff72b5b-2a2a-11e7-8c7e-b353bd2f7989

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

I have decided that it is better to fix the error and let the users see the change than to hide it via a state migration

screen shot 2017-04-11 at 00 55 15

@stack72 stack72 force-pushed the f-aws-cloudfront-custom-origin-timeouts branch from 8ff95bf to 5678ce2 Compare April 5, 2017 11:29
@stack72 stack72 changed the title provider/aws: Add support for CustomOrigin timeouts to aws_cloudfront_distribution [WIP] provider/aws: Add support for CustomOrigin timeouts to aws_cloudfront_distribution Apr 5, 2017
@stack72 stack72 force-pushed the f-aws-cloudfront-custom-origin-timeouts branch from 5678ce2 to 51cde86 Compare April 5, 2017 13:36
@mbfrahry
Copy link
Member

mbfrahry commented Apr 7, 2017

This patch will fix 6 failing TestAccAWSCloudFrontDistribution tests

@stack72 stack72 force-pushed the f-aws-cloudfront-custom-origin-timeouts branch 3 times, most recently from ad1775d to c122394 Compare April 10, 2017 21:32
@stack72 stack72 changed the title [WIP] provider/aws: Add support for CustomOrigin timeouts to aws_cloudfront_distribution provider/aws: Add support for CustomOrigin timeouts to aws_cloudfront_distribution Apr 10, 2017
@stack72 stack72 force-pushed the f-aws-cloudfront-custom-origin-timeouts branch from c122394 to c5a9447 Compare April 17, 2017 22:30
@stack72 stack72 changed the title provider/aws: Add support for CustomOrigin timeouts to aws_cloudfront_distribution [WIP] provider/aws: Add support for CustomOrigin timeouts to aws_cloudfront_distribution Apr 25, 2017
@stack72 stack72 changed the title [WIP] provider/aws: Add support for CustomOrigin timeouts to aws_cloudfront_distribution provider/aws: Add support for CustomOrigin timeouts to aws_cloudfront_distribution Apr 26, 2017
@fourseven
Copy link

We've run into this too. I'm guessing that AWS has changed an API without making it backwards compatible, and would prefer to update my terraform files than have a hidden state migration occur to remedy this, even if it's another terraform release away.

@stack72 stack72 merged commit 011cab5 into master Apr 26, 2017
@stack72 stack72 deleted the f-aws-cloudfront-custom-origin-timeouts branch April 26, 2017 14:14
@rbnunes
Copy link

rbnunes commented May 4, 2017

Is this live on the latest release? I cannot still apply changes. I either get invalid or unknown key: origin_read_timeout or IllegalUpdate: OriginReadTimeout is required for updates.

@stack72
Copy link
Contributor Author

stack72 commented May 4, 2017

Hi @rbnunes

This will not be released until 0.9.5

Paul

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants