Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/kubernetes: Add support for persistent_volume_claim #13527

Merged
merged 1 commit into from
Apr 12, 2017

Conversation

radeksimko
Copy link
Member

Test plan

make testacc TEST=./builtin/providers/kubernetes TESTARGS='-run=TestAccKubernetesPersistentVolumeClaim_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/11 08:29:55 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/kubernetes -v -run=TestAccKubernetesPersistentVolumeClaim_ -timeout 120m
=== RUN   TestAccKubernetesPersistentVolumeClaim_basic
--- PASS: TestAccKubernetesPersistentVolumeClaim_basic (3.27s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_importBasic
--- PASS: TestAccKubernetesPersistentVolumeClaim_importBasic (4.17s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_volumeMatch
--- PASS: TestAccKubernetesPersistentVolumeClaim_volumeMatch (22.80s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_labelsMatch
--- PASS: TestAccKubernetesPersistentVolumeClaim_labelsMatch (11.06s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_labelsMatchExpression
--- PASS: TestAccKubernetesPersistentVolumeClaim_labelsMatchExpression (3.07s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_volumeUpdate
--- PASS: TestAccKubernetesPersistentVolumeClaim_volumeUpdate (15.05s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/kubernetes	59.511s

Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mind formatting documentation examples with 2 spaces, and using the new hcl tag for the code block?

@radeksimko radeksimko force-pushed the f-k8s-persistent-volume-claim branch from 7ecd8c9 to d1da74f Compare April 11, 2017 16:27
@radeksimko
Copy link
Member Author

Updated, thanks for the catch, I will merge it on green.

@radeksimko radeksimko merged commit 1cf0cd8 into master Apr 12, 2017
@radeksimko radeksimko deleted the f-k8s-persistent-volume-claim branch April 12, 2017 07:33
fatmcgav pushed a commit to fatmcgav/terraform that referenced this pull request Apr 12, 2017
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants