terraform remote: fix for state files containing an upper case remote type #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cached state file contains a remote type field with upper case characters, eg 'Consul', it was no longer possible to find the 'consul' remote plugin.
koendc
changed the title
|
Thanks for this! The downcase seems okay to me, but going to let @mitchellh chime in here in case he has a better solution in mind. 👍 |
|
Ah, yeah. I added the downcase to the CLI but not here. I think this can be unit tested as well. I'll add the test and CC you. |
mitchellh
added a commit
that referenced
this pull request
Apr 14, 2015
command/state: fix for state files containing an upper case remote type
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform 0.3.7 saved the remote type in the state as it was passed on the command line. The current code expects lower case remote types. This error appears after a terraform upgrade to master:
This change makes state files created by older versions of terraform usable again.