Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws_network_acl_rule if not found #13608

Merged
merged 1 commit into from
Apr 16, 2017
Merged

Remove aws_network_acl_rule if not found #13608

merged 1 commit into from
Apr 16, 2017

Conversation

ewbankkit
Copy link
Contributor

Fixes the first part of #13489.
If a NACL rule can't be found during the Read pass remove it.

Acceptance test:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSNetworkAclRule_deleteRule'

@stack72
Copy link
Contributor

stack72 commented Apr 16, 2017

LGTM! Thanks for this :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSNetworkAclRule_'                                           ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/17 01:33:29 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSNetworkAclRule_ -timeout 120m
=== RUN   TestAccAWSNetworkAclRule_basic
--- PASS: TestAccAWSNetworkAclRule_basic (42.63s)
=== RUN   TestAccAWSNetworkAclRule_missingParam
--- PASS: TestAccAWSNetworkAclRule_missingParam (23.59s)
=== RUN   TestAccAWSNetworkAclRule_ipv6
--- PASS: TestAccAWSNetworkAclRule_ipv6 (53.92s)
=== RUN   TestAccAWSNetworkAclRule_allProtocol
--- PASS: TestAccAWSNetworkAclRule_allProtocol (82.74s)
=== RUN   TestAccAWSNetworkAclRule_deleteRule
--- PASS: TestAccAWSNetworkAclRule_deleteRule (38.96s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	241.879s

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants