Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws_vpc_dhcp_options if not found #13610

Merged
merged 1 commit into from
Apr 16, 2017
Merged

Remove aws_vpc_dhcp_options if not found #13610

merged 1 commit into from
Apr 16, 2017

Conversation

ewbankkit
Copy link
Contributor

Fixes the second part of #13489.
If DHCP Options can't be found during the Read pass, remove.

Acceptance test:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDHCPOptions_deleteOptions'

@stack72
Copy link
Contributor

stack72 commented Apr 16, 2017

LGTM! Thanks for this :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDHCPOptions_'                                              ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/17 01:29:17 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDHCPOptions_ -timeout 120m
=== RUN   TestAccAWSDHCPOptions_importBasic
--- PASS: TestAccAWSDHCPOptions_importBasic (25.63s)
=== RUN   TestAccAWSDHCPOptions_basic
--- PASS: TestAccAWSDHCPOptions_basic (25.22s)
=== RUN   TestAccAWSDHCPOptions_deleteOptions
--- PASS: TestAccAWSDHCPOptions_deleteOptions (19.27s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	70.179s

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants