provider/google: BigQuery Table #13743
Conversation
heimweh
changed the title
| }, | ||
|
|
||
| // Description: [Optional] The field description. The maximum length is | ||
| // 16K characters. |
There was a problem hiding this comment.
Just curious, how do you know the max length? I don't see it documented.
|
|
||
| // Schema: [Optional] Describes the schema of this table. | ||
| "schema": { | ||
| Type: schema.TypeString, |
There was a problem hiding this comment.
Why a json string instead of a nested object?
There was a problem hiding this comment.
I left this as a JSON string, because I wasn't sure what would be the preferred way.
I'd be happy to replace this and add support for defining the schema in Terraform directly instead.
I'll take a look and see if I can get that to work :)
There was a problem hiding this comment.
Hi @danawillow, sorry for the delay here.
I started working on this but since TableSchema (https://godoc.org/google.golang.org/api/bigquery/v2#TableFieldSchema) can have an arbitrary depth of record fields I'm not entirely sure I can get this to work with helper/schema.
With the current JSON string implementation, one could either define the schema inline or for more complex schemas use for example the $(file()) interpolation function.
I'm not quite sure how to proceed here, so if you have any ideas please let me know :)
There was a problem hiding this comment.
Ah, I didn't realize the arbitrary nesting earlier. I think this is the best way, then. Thanks for the clarification!
| "time_partitioning": &schema.Schema{ | ||
| Type: schema.TypeList, | ||
| Optional: true, | ||
| MinItems: 1, |
There was a problem hiding this comment.
Having a MinItems: 1 on an Optional field is a bit confusing. Can you make it one or the other?
|
|
||
| func resourceBigQueryTableParseID(id string) (string, string, string) { | ||
| // projectID, datasetID, tableID | ||
| parts := strings.FieldsFunc(id, func(r rune) bool { return r == ':' || r == '.' }) |
There was a problem hiding this comment.
Can you point me to where this is documented? All I'm seeing for id is An opaque ID uniquely identifying the table which makes me think it doesn't have a guaranteed format.
There was a problem hiding this comment.
Good catch! 👍 I must have missed that part of the documentation.
While it seems to work, I totally agree that it doesn't seem to be of a guaranteed format.
I'll push a fix for this.
There was a problem hiding this comment.
Have you gotten to this yet? It probably works as-is so I'm not too concerned, but it would be nice to have some confidence.
(a pretty easy fix would be to store the expected id as the id instead of the returned one)
There was a problem hiding this comment.
@danawillow thanks for the quick feedback :)
I totally agree, just pushed a fix that should set the expected ID and format.
|
|
||
| * `type` - (Required) The only type supported is DAY, which will generate | ||
| one partition per day based on data loading time. | ||
| ## Attributes Reference |
|
Thanks, LGTM! Merging now so this gets in before 0.9.5 :) |
|
Awesome! :) thanks @danawillow! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This PR adds support for BigQuery tables.
This PR is dependent on the resource and changes in #13436.