Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws/spot_fleet_request: fixed reading network associate_public_ip_address configuration [closes #12974]] #13748

Merged
merged 1 commit into from
Jun 7, 2017
Merged

provider/aws/spot_fleet_request: fixed reading network associate_public_ip_address configuration [closes #12974]] #13748

merged 1 commit into from
Jun 7, 2017

Conversation

hrach
Copy link
Contributor

@hrach hrach commented Apr 18, 2017

No description provided.

@hrach hrach changed the title [WIP] provider/aws/spot_fleet_request: fixed reading network associate_public_ip_address configuration [WIP] provider/aws/spot_fleet_request: fixed reading network associate_public_ip_address configuration [closes #12974]] Apr 18, 2017
@hrach
Copy link
Contributor Author

hrach commented Apr 18, 2017

This fixes #12974. Tested manually for my testcase. I tried to write a test, but I'm failing to do it. It's quite magic for me and I'm not sure what the test is actually testing. Could someone point me into right direction?

@hrach hrach changed the title [WIP] provider/aws/spot_fleet_request: fixed reading network associate_public_ip_address configuration [closes #12974]] provider/aws/spot_fleet_request: fixed reading network associate_public_ip_address configuration [closes #12974]] Apr 18, 2017
@dashkb
Copy link

dashkb commented Apr 19, 2017

@hrach I'd be happy to pull and try this out but it seems to me the only changes you made are commented out (and you changed the tests). Are you sure you fixed the problem?

@hrach
Copy link
Contributor Author

hrach commented Apr 20, 2017 •
edited
Loading

@dashkb sorry, the second commit is only for confirming that tests test the bug, it revealed that tests doesn't fail :D I will remove the second commit for now.

@vcastellm
Copy link

This also bite us, thank you for the patch

@lesykm
Copy link

lesykm commented Jun 6, 2017 •
edited
Loading

Will this patch be merged to master?

catsby
catsby approved these changes Jun 7, 2017
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@catsby catsby merged commit 70e8d2d into hashicorp:master Jun 7, 2017
@catsby catsby mentioned this pull request Jun 7, 2017
Closed
@hrach hrach deleted the aws_spot_fleet_request_public_ip branch June 8, 2017 10:24
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hrach @dashkb @vcastellm @lesykm @catsby @mbfrahry