Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/rabbitmq: Allow users without tags #13798

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

jtopjian
Copy link
Contributor

This commit makes the tags attribute optional for users. It also
handles cases when a user defines a tag as an empty string ("").

Fixes #12296

This commit makes the tags attribute optional for users. It also
handles cases when a user defines a tag as an empty string ("").
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

% make testacc TEST=./builtin/providers/rabbitmq                                            130 ↵ ✹ ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/20 20:09:21 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/rabbitmq -v  -timeout 120m
=== RUN   TestAccBinding_importBasic
--- PASS: TestAccBinding_importBasic (0.41s)
=== RUN   TestAccExchange_importBasic
--- PASS: TestAccExchange_importBasic (0.23s)
=== RUN   TestAccPermissions_importBasic
--- PASS: TestAccPermissions_importBasic (0.21s)
=== RUN   TestAccPolicy_importBasic
--- PASS: TestAccPolicy_importBasic (0.24s)
=== RUN   TestAccQueue_importBasic
--- PASS: TestAccQueue_importBasic (0.24s)
=== RUN   TestAccUser_importBasic
--- PASS: TestAccUser_importBasic (0.07s)
=== RUN   TestAccVhost_importBasic
--- PASS: TestAccVhost_importBasic (0.16s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccBinding
--- PASS: TestAccBinding (0.27s)
=== RUN   TestAccExchange
--- PASS: TestAccExchange (0.21s)
=== RUN   TestAccPermissions
--- PASS: TestAccPermissions (0.21s)
=== RUN   TestAccPolicy
--- PASS: TestAccPolicy (0.22s)
=== RUN   TestAccQueue
--- PASS: TestAccQueue (0.25s)
=== RUN   TestAccUser_basic
--- PASS: TestAccUser_basic (0.11s)
=== RUN   TestAccUser_emptyTag
--- PASS: TestAccUser_emptyTag (0.17s)
=== RUN   TestAccUser_noTags
--- PASS: TestAccUser_noTags (0.11s)
=== RUN   TestAccVhost
--- PASS: TestAccVhost (0.15s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/rabbitmq	3.255s

@stack72 stack72 merged commit 6262a73 into hashicorp:master Apr 20, 2017
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/rabbitmq: ressource rabbitmq_user with no tags lead to a terraform crash
2 participants