Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Compute Forwarding Rule ports removal not applying #13820

Closed
owensk opened this issue Apr 20, 2017 · 2 comments · Fixed by #13833
Closed

Google Compute Forwarding Rule ports removal not applying #13820

owensk opened this issue Apr 20, 2017 · 2 comments · Fixed by #13833

Comments

@owensk
Copy link

owensk commented Apr 20, 2017

Terraform Version

Terraform v0.9.3

Affected Resource(s)

  • google_compute_forwarding_rule

Terraform Configuration Files

Initial Config:

resource "google_compute_forwarding_rule" "linkerd-forwarding-rule" {
  name                  = "linkerd-forwarding-rule"
  backend_service       = "${google_compute_region_backend_service.linkerd-regional-backend-service.self_link}"
  ports                 = ["7007","7019","7021","7029"]
  load_balancing_scheme = "INTERNAL"
}

Changed config:

resource "google_compute_forwarding_rule" "linkerd-forwarding-rule" {
  name                  = "linkerd-forwarding-rule"
  backend_service       = "${google_compute_region_backend_service.linkerd-regional-backend-service.self_link}"
  load_balancing_scheme = "INTERNAL"
}

Debug Output

Initial plan output:

~ module.linkerd-prod.google_compute_forwarding_rule.linkerd-forwarding-rule
    ports.#:          "4" => "0"
    ports.254306664:  "7007" => ""
    ports.3565006559: "7021" => ""
    ports.3668322029: "7029" => ""
    ports.4052448558: "7019" => ""

Apply Ouput:

module.linkerd-prod.google_compute_forwarding_rule.linkerd-forwarding-rule: Modifying... (ID: linkerd-forwarding-rule)
  ports.#:          "4" => "0"
  ports.254306664:  "7007" => ""
  ports.3565006559: "7021" => ""
  ports.3668322029: "7029" => ""
  ports.4052448558: "7019" => ""

Second Plan Output:

~ module.linkerd-prod.google_compute_forwarding_rule.linkerd-forwarding-rule
    ports.#:          "4" => "0"
    ports.254306664:  "7007" => ""
    ports.3565006559: "7021" => ""
    ports.3668322029: "7029" => ""
    ports.4052448558: "7019" => ""

Expected Behavior

Should have removed the optional ports configuration from the forwarding rule and started forwarding all ports as specified in the documentation

Actual Behavior

DIdn't appear to change google forwarding rule at all. Plan still shows desired change as well.

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

  1. Config to look like first snippet
  2. terraform plan
  3. Config to look like second snippet
  4. terraform plan to see change
  5. terraform apply to attempt change
  6. terraform plan to see failed change still pending
@owensk owensk changed the title Google Computer Forwarding Rule ports removal not applying Google Compute Forwarding Rule ports removal not applying Apr 20, 2017
@owensk
Copy link
Author

owensk commented Apr 21, 2017

This will now just fail on apply per #13822

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants