command/validate: Check that all variables are specified #13872
Conversation
radeksimko
force-pushed
the
f-validate-var-check
branch
from
d3d74d8 to
ad623ec
Compare
radeksimko
force-pushed
the
f-validate-var-check
branch
from
ad623ec to
afb729d
Compare
command/validate.go
Outdated
|
|
||
| Options: | ||
|
|
||
| -config-only If specified, the command will check basic syntax of |
There was a problem hiding this comment.
This flag name feels like it could hurt in the long run if validate were to get other tweakables like this.
Perhaps this could be -check-variables=false, with the default being -check-variables=true, and then if we add other things in the future they could be like -check-types=false or whatever, defaulting to everything being on by default.
There was a problem hiding this comment.
That's a good idea, I'll change that to -check-variables=[true]
radeksimko
force-pushed
the
f-validate-var-check
branch
from
418a5fa to
f694871
Compare
|
@apparentlymart Fixed. |
| The command-line flags are all optional. The available flags are: | ||
|
|
||
| * `-config-only` - If specified, the command will check basic syntax of the |
There was a problem hiding this comment.
This doc is lagging behind the changes to the interface.
There was a problem hiding this comment.
Doh, I did grep through the code, but only in command/*, will fix that in a minute.
radeksimko
force-pushed
the
f-validate-var-check
branch
from
f694871 to
2873b2f
Compare
radeksimko
changed the title
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Closes #8588
This is a rebased #8588. All the hard work is still credited to @dtolnay - I just patched his PR to comply with the recent changes to context.
This is introducing BC in the sense that default behaviour is changing, but previous behaviour is still available under a flag.
Either way we should mark this as BC in Changelog and also I'd like someone to review this patched PR before I merge it.