providers/heroku: add heroku_space resource #13921

bernerdschaefer · 2017-04-25T00:48:12Z

This introduces a new heroku_space resource for managing Heroku Private Spaces.

It creates, renames, and destroys private spaces in the configured region.

Combined with #13862, this should resolve #7059.

Acceptance test results

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/24 17:43:53 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/heroku -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccHerokuAddon_Basic
--- PASS: TestAccHerokuAddon_Basic (4.19s)
=== RUN   TestAccHerokuAddon_noPlan
--- PASS: TestAccHerokuAddon_noPlan (5.59s)
=== RUN   TestAccHerokuApp_Basic
--- PASS: TestAccHerokuApp_Basic (2.81s)
=== RUN   TestAccHerokuApp_NameChange
--- PASS: TestAccHerokuApp_NameChange (5.03s)
=== RUN   TestAccHerokuApp_NukeVars
--- PASS: TestAccHerokuApp_NukeVars (5.05s)
=== RUN   TestAccHerokuApp_Organization
--- PASS: TestAccHerokuApp_Organization (3.16s)
=== RUN   TestAccHerokuCert_Basic
--- PASS: TestAccHerokuCert_Basic (19.18s)
=== RUN   TestAccHerokuDomain_Basic
--- PASS: TestAccHerokuDomain_Basic (3.28s)
=== RUN   TestAccHerokuDrain_Basic
--- PASS: TestAccHerokuDrain_Basic (3.30s)
=== RUN   TestAccHerokuSpace_Basic
--- PASS: TestAccHerokuSpace_Basic (7.24s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/heroku	58.851s

bernerdschaefer · 2017-04-25T00:49:27Z

builtin/providers/heroku/resource_heroku_space.go

+	d.SetId(space.ID)
+	log.Printf("[INFO] Space ID: %s", d.Id())
+
+	setSpaceAttributes(d, (*heroku.Space)(space))


If the vendored version of heroku-go is updated, this type conversion can be dropped, as the Space methods have been updated to all return *heroku.Space.

Mind adding an inline comment here noting this?

Certainly! Done in e7c904a.

bernerdschaefer · 2017-04-25T00:50:35Z

website/source/docs/providers/heroku/r/space.html.markdown

+# Create a new Heroku app in test-space
+resource "heroku_app" "default" {
+  name = "test-app"
+  space = "${heroku_space.default.name}"


This bit of documentation is only accurate if #13862 is also merged.

bernerdschaefer · 2017-04-25T16:18:07Z

builtin/providers/heroku/resource_heroku_space_test.go

+			if org == "" {
+				t.Skip("HEROKU_ORGANIZATION is not set; skipping test.")
+			}
+		},


I also wonder if this needs an additional flag, like HEROKU_ENABLE_SPACES=1, since not all organizations can currently create private spaces.

This will return an API error if the organization cannot create a private space, yeah?

That's right, this should return a 403 Forbidden error for organizations without space management access.

Okay cool, if the error returned from the API is sufficiently descriptive enough, I don't think we'll need to add the env-var.

grubernaut

LGTM, few minor nits though, nothing major. Thanks!

grubernaut · 2017-04-25T22:06:09Z

builtin/providers/heroku/resource_heroku_space.go

+	d.SetId(space.ID)
+	log.Printf("[INFO] Space ID: %s", d.Id())
+
+	setSpaceAttributes(d, (*heroku.Space)(space))


Mind adding an inline comment here noting this?

grubernaut · 2017-04-25T22:06:59Z

builtin/providers/heroku/resource_heroku_space_test.go

+			if org == "" {
+				t.Skip("HEROKU_ORGANIZATION is not set; skipping test.")
+			}
+		},


This will return an API error if the organization cannot create a private space, yeah?

grubernaut · 2017-04-25T22:07:35Z

website/source/docs/providers/heroku/r/space.html.markdown

+## Example Usage
+
+```hcl
+# Create a new Heroku space


Please use // for inline comments in examples

grubernaut · 2017-04-25T22:07:42Z

website/source/docs/providers/heroku/r/space.html.markdown

+  region = "virginia"
+}
+
+# Create a new Heroku app in test-space


Here as well

Done in 26d6a56.

grubernaut

LGTM! Thanks!

providers/heroku: add heroku_space resource

ghost · 2020-04-13T02:18:15Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

bernerdschaefer added 3 commits April 24, 2017 17:08

Add first failing test for heroku_space

4325749

Implementation

dbf82e6

Website

de54855

bernerdschaefer commented Apr 25, 2017

View reviewed changes

Fix typo in docs

81e8db5

tombuildsstuff added enhancement provider/heroku labels Apr 25, 2017

bernerdschaefer commented Apr 25, 2017

View reviewed changes

grubernaut suggested changes Apr 25, 2017

View reviewed changes

bernerdschaefer added 2 commits April 25, 2017 15:27

Use // for inline comments

26d6a56

Add note about type conversion

e7c904a

grubernaut approved these changes Apr 25, 2017

View reviewed changes

grubernaut merged commit 22ed31c into hashicorp:master Apr 25, 2017

vanstee pushed a commit to vanstee/terraform that referenced this pull request Sep 28, 2017

Merge pull request hashicorp#13921 from bernerdschaefer/bs-create-space

602f6f6

providers/heroku: add heroku_space resource

vanstee pushed a commit to vanstee/terraform that referenced this pull request Sep 28, 2017

Merge pull request hashicorp#13921 from bernerdschaefer/bs-create-space

090b12f

providers/heroku: add heroku_space resource

ghost locked and limited conversation to collaborators Apr 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

providers/heroku: add heroku_space resource #13921

providers/heroku: add heroku_space resource #13921

bernerdschaefer commented Apr 25, 2017

bernerdschaefer Apr 25, 2017

grubernaut Apr 25, 2017

bernerdschaefer Apr 25, 2017

bernerdschaefer Apr 25, 2017

bernerdschaefer Apr 25, 2017

grubernaut Apr 25, 2017

bernerdschaefer Apr 25, 2017

grubernaut Apr 25, 2017

grubernaut left a comment

grubernaut Apr 25, 2017

grubernaut Apr 25, 2017

grubernaut Apr 25, 2017

grubernaut Apr 25, 2017

bernerdschaefer Apr 25, 2017

grubernaut left a comment

ghost commented Apr 13, 2020

providers/heroku: add heroku_space resource #13921

providers/heroku: add heroku_space resource #13921

Conversation

bernerdschaefer commented Apr 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grubernaut left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grubernaut left a comment

Choose a reason for hiding this comment

ghost commented Apr 13, 2020