Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/triton: Read TRITON_* as well as SDC_* #14000

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Apr 26, 2017

The Triton CLI tools have been using TRITON_* as their configuration environment variables for some time now. This commit makes Terraform use them in preference to any SDC_* variables set, and allows Terraform to work with the credentials set by the triton env in the CLI.

The Triton CLI tools have been using TRITON_* as their configuration
environment variables for some time now. This commit makes Terraform use
them in preference to any SDC_* variables set, and allows Terraform to
work with the credentials set by the `triton env` in the CLI.
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grubernaut
Copy link
Contributor

@jen20 thought to himself... what's a quick way to get PR #14000

@jen20
Copy link
Contributor Author

jen20 commented Apr 26, 2017

Hah - I only saw the number when I opened it ;-)

@jen20 jen20 merged commit 77a24f8 into master Apr 26, 2017
@jen20 jen20 deleted the triton-envvars branch April 26, 2017 17:56
@stack72
Copy link
Contributor

stack72 commented Apr 26, 2017

Sure ya did ;)

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants