Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/heroku: add heroku_app_feature resource #14035

Merged
merged 1 commit into from
Apr 27, 2017

Conversation

danp
Copy link
Contributor

@danp danp commented Apr 27, 2017

All credit to @bernerdschaefer, just PR'ing something he did internally.

Also, 👋 @catsby!

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

TF_ACC=1 go test ./builtin/providers/heroku -v -run=TestAccHerokuAppFeature -timeout 120m
=== RUN   TestAccHerokuAppFeature
--- PASS: TestAccHerokuAppFeature (6.97s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/heroku 6.982s

@catsby catsby merged commit e495c6b into hashicorp:master Apr 27, 2017
@catsby
Copy link
Contributor

catsby commented Apr 27, 2017

@danp ah, I merged this before I noticed the new resource wasn't in the layout! I added that in d6560b9 and had to do a little hack on the heroku_app docs to get the regex to only highlight one or the other on our docs page. The regex hack is a blemish but it works for now 😄

@danp
Copy link
Contributor Author

danp commented Apr 27, 2017

Oh, thanks! Will be sure to update that list too next time.

@danp danp deleted the heroku-app-feature branch April 27, 2017 18:39
vanstee pushed a commit to vanstee/terraform that referenced this pull request Sep 28, 2017
vanstee pushed a commit to vanstee/terraform that referenced this pull request Sep 28, 2017
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants