Added data source for aws_efs_file_system

[craigknott]

heavily based off of resource_aws_efs_file_systems read method.

[catsby]

Looks like go vet is failing on the Errorf line 53:

• builtin/providers/aws/data_source_aws_efs_file_system.go:53: no formatting directive in Errorf call

[stack72]

Hi @craigknott

Thanks so much for the work here - I have made a few changes to the code as follows:

• renamed id to be file_system_id - ID is generally not something we use as a parameter name
• changed performance_mode to be computed only as we never use it as a parameter
• changes file_system_id and creation_token to be forcenew so that any changes forces a new data source

I also added some documentation as well. You tests passed as expected which was awesome :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccDataSourceAwsEfsFileSystem'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/29 11:17:59 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccDataSourceAwsEfsFileSystem -timeout 120m
=== RUN   TestAccDataSourceAwsEfsFileSystem
--- PASS: TestAccDataSourceAwsEfsFileSystem (48.82s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	48.844s

Thanks for the work here :) I just merged this manually

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.