Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for IAMDatabaseAuthenticationEnabled #14092

Merged
merged 1 commit into from
May 1, 2017

Conversation

gazoakley
Copy link
Contributor

@gazoakley gazoakley commented Apr 29, 2017

Adds a new iam_database_authentication_enabled attribute to aws_db_instance and aws_rds_cluster. Addresses #14069

@gazoakley
Copy link
Contributor Author

Acceptance tests passing:

gaz$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBInstance_iamAuth'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/30 08:43:24 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBInstance_iamAuth -timeout 120m
=== RUN   TestAccAWSDBInstance_iamAuth
--- PASS: TestAccAWSDBInstance_iamAuth (491.42s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	491.439s
gaz$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRDSCluster_iamAuth'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/30 08:58:45 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRDSCluster_iamAuth -timeout 120m
=== RUN   TestAccAWSRDSCluster_iamAuth
--- PASS: TestAccAWSRDSCluster_iamAuth (134.36s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	134.380s

@gazoakley gazoakley changed the title [WIP] provider/aws: Add support for IAMDatabaseAuthenticationEnabled provider/aws: Add support for IAMDatabaseAuthenticationEnabled Apr 30, 2017
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@grubernaut grubernaut merged commit 86903a9 into hashicorp:master May 1, 2017
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants