Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: support tenancy for spot fleets #14163

Merged
merged 3 commits into from
May 3, 2017
Merged

provider/aws: support tenancy for spot fleets #14163

merged 3 commits into from
May 3, 2017

Conversation

paddycarver
Copy link
Contributor

Add the placement_tenancy attribute to the aws_spot_fleet_request
resource so users can request instances use dedicated hardware.

Fixes #14152.

@paddycarver
provider/aws: support tenancy for spot fleets
a345cc4 
Add the `placement_tenancy` attribute to the `aws_spot_fleet_request`
resource so users can request instances use dedicated hardware.

Fixes #14152.
grubernaut
grubernaut suggested changes May 3, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor nit, and documentation needed.

builtin/providers/aws/resource_aws_spot_fleet_request_test.go Outdated
instance_type = "m1.small"
ami = "ami-d06a90b0"
key_name = "${aws_key_pair.debugging.key_name}"
placement_tenancy = "dedicated"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd spacing here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch, thanks.

@paddycarver
Copy link
Contributor Author

Re: documentation, I looked into adding documentation with the rest of the launch_specification documentation, only to find the launch_specification documentation doesn't list individual properties. It just points to the AWS docs about the properties, which document the placement option. Do you have any suggestions on where you'd like to see the docs added? As far as I can tell, I'm following the established pattern, but there's a very good chance I'm just missing where I should be looking.

@grubernaut
Copy link
Contributor

@paddycarver :/ odd, assumed it was documented similarly to our other resources. Perhaps just add it to the one of the launch_specification examples shown in the documentation? We should look into expanding that whole configuration block into it's own documentation section, but that's out of scope for this pr

@paddycarver
Add example of placement to sfr docs.
5341d57 
Add an example usage of the placement_tenancy field to spot fleet
request docs.
@paddycarver
Copy link
Contributor Author

Cool, last push should do that. 👍 Let me know if I misunderstood.

grubernaut
grubernaut approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddycarver paddycarver merged commit c043f11 into master May 3, 2017
@grubernaut grubernaut deleted the paddy_14152_sfr_tenancy branch May 4, 2017 16:48
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: aws_spot_fleet_request placement_tenancy property
2 participants
@paddycarver @grubernaut