provider/google: Move 404 checking into a function in provider.go, call it from instance and IGM #14190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll it from instance and IGM
paddycarver
suggested changes
May 3, 2017
builtin/providers/google/provider.go
Outdated
| @@ -250,3 +251,15 @@ func getNetworkNameFromSelfLink(network string) (string, error) { | |||
|
|
|||
| return network, nil | |||
| } | |||
|
|
|||
| func readError(err error, d *schema.ResourceData, resource string) error { | |||
There was a problem hiding this comment.
nit: maybe handleNotFoundError? readError doesn't really indicate this is for 404s, to me.
paddycarver
approved these changes
May 4, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for #13943. It fixes the specific concern by adding in 404 checking for
resource_compute_instance_group_manager, and also shows the new function being reused inresource_compute_instance(note that it also exposed a bug- if there is a 404, we should returnnilinstead of an error). If this looks good, I'll check it in and then open up a separate PR for the rest of the resources.