provider/google: Add support for privateIpGoogleAccess on subnetworks

[mattrobenolt]

provider "google" {
  region = "us-central1"
}

resource "google_compute_network" "foo_network" {
  name = "foo"
}

resource "google_compute_subnetwork" "foo_subnetwork" {
  name          = "foo"
  network       = "${google_compute_network.foo_network.self_link}"
  ip_cidr_range = "10.0.0.0/24"
  region        = "us-central1"
  private_ip_google_access = true
}

data "google_compute_subnetwork" "foo_data" {
    name = "${google_compute_subnetwork.foo_subnetwork.name}"
}

<= data.google_compute_subnetwork.foo_data
    description:              "<computed>"
    gateway_address:          "<computed>"
    ip_cidr_range:            "<computed>"
    name:                     "foo"
    network:                  "<computed>"
    private_ip_google_access: "<computed>"
    self_link:                "<computed>"

+ google_compute_network.foo_network
    gateway_ipv4: "<computed>"
    name:         "foo"
    self_link:    "<computed>"

+ google_compute_subnetwork.foo_subnetwork
    gateway_address:          "<computed>"
    ip_cidr_range:            "10.0.0.0/24"
    name:                     "foo"
    network:                  "${google_compute_network.foo_network.self_link}"
    private_ip_google_access: "true"
    region:                   "us-central1"
    self_link:                "<computed>"


Plan: 2 to add, 0 to change, 0 to destroy.

[danawillow]

Thanks for the contribution, @mattrobenolt! Looks good!

TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccDataSourceGoogleSubnetwork -timeout 120m
=== RUN   TestAccDataSourceGoogleSubnetwork
--- PASS: TestAccDataSourceGoogleSubnetwork (68.34s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	68.468s

TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeSubnetwork -timeout 120m
=== RUN   TestAccComputeSubnetwork_basic
--- PASS: TestAccComputeSubnetwork_basic (75.76s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	75.884s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.