Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the wording of an error message #14256

Merged
merged 1 commit into from
May 5, 2017
Merged

Improve the wording of an error message #14256

merged 1 commit into from
May 5, 2017

Conversation

alexwlchan
Copy link
Contributor

Previously the following code:

resource "aws_dynamodb_table" "example" {
  name             = "example"
  read_capacity    = 5
  write_capacity   = 5
  hash_key         = "my_id"
  stream_enabled   = true
  stream_view_type = "NOT_A_VALID_STREAM_VIEW_TYPE"

  attribute {
    name = "my_id"
    type = "S"
  }
}

would yield an error message when you ran terraform plan:

* aws_dynamodb_table.bookmarks: "stream_view_type" be a valid DynamoDB StreamViewType

This sentence doesn't make sense – this patch adds the missing "must".

Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@grubernaut grubernaut merged commit 00de514 into hashicorp:master May 5, 2017
@alexwlchan alexwlchan deleted the fix-error-message branch May 5, 2017 21:16
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants