Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds description to command schema in rundeck_job resource #14352

Merged

Conversation

gerbenjacobs
Copy link

This change allows you to add descriptions to command/step blocks in Rundeck. This is especially nice when viewing a definition that contains multiple script steps.

Gerben Jacobs added 2 commits May 10, 2017 14:09
Change-Id: I90e729dd6864b79773c80aedb39991eb251ab821
Change-Id: Id40ae356eaaedf9656b7e38d96d8eb292c9d2cea
@stack72
Copy link
Contributor

stack72 commented May 11, 2017

Thanks for this @gerbenjacobs :)

This LGTM and the tests pass as expected

% make testacc TEST=./builtin/providers/rundeck                                                    ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/11 14:29:01 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/rundeck -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccJob_basic
--- PASS: TestAccJob_basic (8.01s)
=== RUN   TestAccPrivateKey_basic
--- PASS: TestAccPrivateKey_basic (1.44s)
=== RUN   TestAccProject_basic
--- PASS: TestAccProject_basic (1.51s)
=== RUN   TestAccPublicKey_basic
--- PASS: TestAccPublicKey_basic (2.60s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/rundeck	13.578s

@stack72 stack72 merged commit 2178981 into hashicorp:master May 11, 2017
@gerbenjacobs gerbenjacobs deleted the feature/rundeck-command-description branch May 13, 2017 20:31
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants