Add namespcace ID attribute

[hauleth]

This commit also introduce id comouted value which is numeric value
used by GitLab to iteract with repository. This should simplify use of
gitlab_project_hook usage and would allow to introduce other resources
as described in #14471

[hauleth]

I am not proficient in Go enough to write tests to cover new functionality though.

[richardc]

This isn't needed. The reason you cite for adding it is to help work with the gitlab_project_hook resource, but if you look at the acceptance tests for that code you'll see that the id is already exposed and used in its tests: https://github.com/hashicorp/terraform/blob/master/builtin/providers/gitlab/resource_gitlab_project_hook_test.go#L189 Its just an automatically exported attribute that all resources get.

[richardc]

Remove this, it's already done elsewhere

[hauleth]

@richardc it would be worth documenting then as I cannot see that in gitlab_project Attributes Reference

[richardc]

Sure, the docs are in the repo too. Probably also worth adding the missing example to gitlab_project_hooks too, so the next user doesn't think that "${gitlab_project.foo.id}" isn't usable already.

[richardc]

Cherry-picking this over to my gitlab_group branch (resulting frankenbranch at https://github.com/richardc/terraform/tree/feature/add_gitlab_group_plus_cherry) does result in the ability to create a project in a group with as simply as this:

resource "gitlab_group" "test1" {
  name = "test1"
  path = "test1"
  visibility_level = "public"
}

resource "gitlab_project" "test1" {
  name = "test1"
  namespace_id = "${gitlab_group.test1.id}"
  description = "A test project! Modify 2"
  visibility_level = "public"
  //issues_enabled = false
}

👍 though it will need docs and tests.

[richardc]

One change needed here, this is optional, so it needs to move from here and go with the d.GetOk("") patterned stuff:

if v, ok := d.GetOk("namespace_id"); ok {
   options.NamespaceID = gitlab.Int(v.(int))
}

[richardc]

Spoke too soon, it breaks the case where a namespace_id isn't provided as you're not handling the optional nature correctly. Notes on how to fix it on the line.

[hauleth]

Fixed -- Łukasz Niemier lukasz@niemier.pl

…

Wiadomość napisana przez Richard Clamp ***@***.***> w dniu 15.05.2017, o godz. 14:09: Spoke too soon, it breaks the case where a namespace_id isn't provided as you're not handling the optional nature correctly. Notes on how to fix it on the line. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14483 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARzN8atig8GPoMrv4x5dwgAp_6fa-K5ks5r6EBwgaJpZM4Na2hq>.

[stack72]

Hi @hauleth

Thanks for the work here and thanks @richardc for the review. I merged #14490 first and now the tests pass as expected:

make testacc TEST=./builtin/providers/gitlab                                                                                         1 ↵ ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/24 13:03:02 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/gitlab -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccGitlabDeployKey_basic
--- PASS: TestAccGitlabDeployKey_basic (36.70s)
=== RUN   TestAccGitlabGroup_basic
--- PASS: TestAccGitlabGroup_basic (21.09s)
=== RUN   TestAccGitlabProjectHook_basic
--- PASS: TestAccGitlabProjectHook_basic (31.13s)
=== RUN   TestAccGitlabProject_basic
--- PASS: TestAccGitlabProject_basic (29.59s)
=== RUN   TestGitlab_validation
--- PASS: TestGitlab_validation (0.00s)
=== RUN   TestGitlab_visbilityHelpers
--- PASS: TestGitlab_visbilityHelpers (0.00s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/gitlab	118.526s

One thing to note - this new param hasn't had any documentation included. Please can you follow up with that?

Thanks

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.