Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Handle Deleted Resources in Floating IP Association #14533

Merged

Conversation

jtopjian
Copy link
Contributor

This commit modifies the openstack_compute_floatingip_associate_v2 resource
to handle cases where the floating IP or instance were deleted outside of
Terraform.

For #14461

This commit modifies the openstack_compute_floatingip_associate_v2 resource
to handle cases where the floating IP or instance were deleted outside of
Terraform.
@jtopjian
Copy link
Contributor Author

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/16 01:37:09 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/openstack -v -run=TestAccComputeV2FloatingIPAssociate -timeout 120m
=== RUN   TestAccComputeV2FloatingIPAssociate_importBasic
--- PASS: TestAccComputeV2FloatingIPAssociate_importBasic (94.97s)
=== RUN   TestAccComputeV2FloatingIPAssociate_basic
--- PASS: TestAccComputeV2FloatingIPAssociate_basic (85.95s)
=== RUN   TestAccComputeV2FloatingIPAssociate_fixedIP
--- PASS: TestAccComputeV2FloatingIPAssociate_fixedIP (82.33s)
=== RUN   TestAccComputeV2FloatingIPAssociate_attachToFirstNetwork
--- PASS: TestAccComputeV2FloatingIPAssociate_attachToFirstNetwork (93.30s)
=== RUN   TestAccComputeV2FloatingIPAssociate_attachToSecondNetwork
--- PASS: TestAccComputeV2FloatingIPAssociate_attachToSecondNetwork (132.66s)
=== RUN   TestAccComputeV2FloatingIPAssociate_attachNew
--- PASS: TestAccComputeV2FloatingIPAssociate_attachNew (129.15s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/openstack      618.396s

@stack72
Copy link
Contributor

stack72 commented May 16, 2017

LGTM :)

@stack72 stack72 merged commit 5842642 into hashicorp:master May 16, 2017
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants