Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/google: Add support for draining_timeout_sec to compute_backend_service. #14559

Merged
merged 4 commits into from
Jun 7, 2017
Merged

provider/google: Add support for draining_timeout_sec to compute_backend_service. #14559

merged 4 commits into from
Jun 7, 2017

Conversation

rileykarson
Copy link
Contributor

Add support for the connection_draining block and draining_timeout_sec to compute_backend_service.

Part 1/2 of #13925.

@danawillow

@danawillow danawillow self-requested a review May 17, 2017 23:02
danawillow
danawillow reviewed Jun 7, 2017
View reviewed changes
builtin/providers/google/resource_compute_backend_service_test.go
@@ -114,6 +114,31 @@ func TestAccComputeBackendService_withBackendAndUpdate(t *testing.T) {
}
}

func TestAccComputeBackendService_withConnectionDraining(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to add a test for update too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@danawillow
Copy link
Contributor 

TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeBackendService_withConnectionDraining -timeout 120m
=== RUN   TestAccComputeBackendService_withConnectionDraining
--- PASS: TestAccComputeBackendService_withConnectionDraining (45.62s)
=== RUN   TestAccComputeBackendService_withConnectionDrainingAndUpdate
--- PASS: TestAccComputeBackendService_withConnectionDrainingAndUpdate (56.97s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	102.733s

@danawillow danawillow merged commit 45d1931 into hashicorp:master Jun 7, 2017
@rileykarson rileykarson mentioned this pull request Jun 13, 2017
Merged
@rileykarson rileykarson mentioned this pull request Aug 3, 2017
Closed
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danawillow danawillow danawillow left review comments

Assignees
No one assigned
Labels
enhancement provider/google-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rileykarson @danawillow @tombuildsstuff